-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Support for ERC-4337 EntryPoint v0.7 #243
Conversation
Pull Request Test Coverage Report for Build 7870582983Details
💛 - Coveralls |
3d1d8a9
to
b94c828
Compare
@@ -1 +1,2 @@ | |||
modules/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and other formatting/linting-related changes were needed to fix the failing CI job. The problem was conflicting eslint-prettier-plugin rules and prettier itself due to misconfiguration.
TLDR: For linting and formatting javascript/typescript code, we use eslint-plugin-prettier, which runs prettier as ESLint rules. For checking formatting, we use a standalone prettier
package instead. After updating dependencies, they introduced conflicting rules. So, ESLint would say that prettier's formatting needs to be corrected and vice versa. To fix this, I updated the prettier script to only format solidity files in the 4337 module and added the examples
directory to .prettierignore
for the global check (since the only app there uses eslint for formatting as well)
798faeb
to
88d3daa
Compare
Closing in favor of #245 |
Re-opening, as we want to potentially include this to an |
Safe4337Module
f955991
to
19ea9d6
Compare
Merging with failing E2E tests (see PR description). |
This PR:
PackedUserOperation
struct with the new packed gas limit fieldaccountGasLimits
that consists of twouint128
packed values(validationGasLimit, callGasLimit)
PackedUserOperation
struct with packed gas fields from entrypoint 0.7.0 #225Forked contracts repo with build artifacts: https://github.com/5afe/account-abstraction
More about 0.7.0 changes: #215
Issues/concerns: