Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[N-04] Add Security Contact to NatSpec #244

Merged
merged 1 commit into from
Feb 7, 2024
Merged

[N-04] Add Security Contact to NatSpec #244

merged 1 commit into from
Feb 7, 2024

Conversation

nlordell
Copy link
Collaborator

Fixes audit issue N-04.

This PR adds the custom security-contact tag to the Safe4337Module contract NatSpec documentation.

Note that the audit issue additionally mentioned that the AddModulesLib contract also needed a security contract, but this was added as part of the NatSpec documentation when resolving L-03 in #241.

@nlordell nlordell requested a review from a team as a code owner January 29, 2024 17:01
@nlordell nlordell requested review from rmeissner, akshay-ap, mmv08 and remedcu and removed request for a team January 29, 2024 17:01
@nlordell nlordell added the audit review A PR to address an issue found during an audit label Jan 29, 2024
@nlordell nlordell merged commit fe7cbfe into main Feb 7, 2024
10 checks passed
@nlordell nlordell deleted the audit/n-04 branch February 7, 2024 13:01
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmv08 mmv08 mmv08 approved these changes

@remedcu remedcu remedcu approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner rmeissner is a code owner automatically assigned from safe-global/safe-protocol

@akshay-ap akshay-ap Awaiting requested review from akshay-ap akshay-ap is a code owner automatically assigned from safe-global/safe-protocol

Assignees
No one assigned
Labels
audit review A PR to address an issue found during an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nlordell @mmv08 @remedcu