Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add limit connection configuration to queue_service #1882

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Add limit connection configuration to queue_service #1882

merged 3 commits into from
Feb 23, 2024

Conversation

moisses89
Copy link
Member

Close #1848

@moisses89 moisses89 requested a review from a team as a code owner February 20, 2024 13:32
@moisses89 moisses89 requested a review from a team as a code owner February 23, 2024 15:57
@moisses89 moisses89 requested a review from Uxio0 February 23, 2024 16:05
Uxio0
Uxio0 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@Uxio0 Uxio0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

safe_transaction_service/events/services/queue_service.py Outdated Show resolved Hide resolved
safe_transaction_service/events/services/queue_service.py Outdated Show resolved Hide resolved
safe_transaction_service/events/services/queue_service.py Show resolved Hide resolved
safe_transaction_service/events/services/queue_service.py Outdated Show resolved Hide resolved
safe_transaction_service/events/tests/test_queue_service.py Outdated Show resolved Hide resolved
safe_transaction_service/events/tests/test_queue_service.py Outdated Show resolved Hide resolved
safe_transaction_service/events/tests/test_queue_service.py Outdated Show resolved Hide resolved
safe_transaction_service/events/services/queue_service.py Outdated Show resolved Hide resolved
@moisses89 @Uxio0
Apply suggestions from code review
fee7b64 
Co-authored-by: Uxío <Uxio0@users.noreply.github.com>
@moisses89 moisses89 merged commit bd4c438 into master Feb 23, 2024
6 checks passed
@moisses89 moisses89 deleted the add_pool_pika_limit branch February 23, 2024 17:35
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Uxio0 Uxio0 Uxio0 approved these changes

@falvaradorodriguez falvaradorodriguez Awaiting requested review from falvaradorodriguez falvaradorodriguez was automatically assigned from safe-global/safe-services

@iamacook iamacook Awaiting requested review from iamacook iamacook was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add configurable limit to pika pool connections
2 participants
@moisses89 @Uxio0