fix(threshold-info): use isChangeThresholdView guard

src/components/tx/confirmation-views/ChangeThreshold/index.tsx

@@ -5,8 +5,8 @@ import commonCss from '@/components/tx-flow/common/styles.module.css'
 import useSafeInfo from '@/hooks/useSafeInfo'
 import { ChangeThresholdReviewContext } from '@/components/tx-flow/flows/ChangeThreshold/context'
 import { ChangeSignerSetupWarning } from '@/features/multichain/components/SignerSetupWarning/ChangeSignerSetupWarning'
-import { SettingsInfoType, type TransactionDetails } from '@safe-global/safe-gateway-typescript-sdk'
-import { isSettingsChangeTxInfo } from '@/utils/transaction-guards'
+import { type TransactionDetails } from '@safe-global/safe-gateway-typescript-sdk'
+import { isChangeThresholdView } from '../utils'
 
 interface ChangeThresholdProps {
   txDetails?: TransactionDetails
@@ -15,11 +15,7 @@ interface ChangeThresholdProps {
 function ChangeThreshold({ txDetails }: ChangeThresholdProps) {
   const { safe } = useSafeInfo()
   const { newThreshold } = useContext(ChangeThresholdReviewContext)
-  const threshold =
-    txDetails &&
-    isSettingsChangeTxInfo(txDetails.txInfo) &&
-    txDetails.txInfo.settingsInfo?.type === SettingsInfoType.CHANGE_THRESHOLD &&
-    txDetails.txInfo.settingsInfo.threshold
+  const threshold = txDetails && isChangeThresholdView(txDetails.txInfo) && txDetails.txInfo.settingsInfo?.threshold
 
   return (
     <>

src/components/tx/confirmation-views/utils.ts

@@ -1,10 +1,12 @@
-import type { TransactionInfo } from '@safe-global/safe-gateway-typescript-sdk'
+import type { ChangeThreshold, SettingsChange, TransactionInfo } from '@safe-global/safe-gateway-typescript-sdk'
 import { SettingsInfoType, TransactionInfoType } from '@safe-global/safe-gateway-typescript-sdk'
 import { ConfirmBatchFlow } from '@/components/tx-flow/flows'
 
 export const isSettingsChangeView = (txInfo: TransactionInfo) => txInfo.type === TransactionInfoType.SETTINGS_CHANGE
 
 export const isConfirmBatchView = (txFlow?: JSX.Element) => txFlow?.type === ConfirmBatchFlow
 
-export const isChangeThresholdView = (txInfo: TransactionInfo) =>
+export const isChangeThresholdView = (
+  txInfo: TransactionInfo,
+): txInfo is SettingsChange & { settingsInfo: ChangeThreshold } =>
   txInfo.type === TransactionInfoType.SETTINGS_CHANGE && txInfo.settingsInfo?.type === SettingsInfoType.CHANGE_THRESHOLD