Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught exception: isUnlock is not a function #1134

Closed
katspaugh opened this issue Nov 13, 2022 · 0 comments · Fixed by #1138
Closed

Uncaught exception: isUnlock is not a function #1134

katspaugh opened this issue Nov 13, 2022 · 0 comments · Fixed by #1138
Assignees
Labels
bug Something isn't working

Comments

@katspaugh
Copy link
Member

katspaugh commented Nov 13, 2022

Bug description

Sentry: https://sentry.io/organizations/gnosis/issues/3732706691/?project=6769196&query=is%3Aunresolved&referrer=issue-stream

Screenshot 2022-11-13 at 08 56 47

It's coming from this code: https://github.com/safe-global/web-core/blob/dev/src/utils/wallets.ts#L30-L33

Probably some versions of MetaMask don't support this method. We need to add a check that it exists.

  if (window.ethereum?._metamask?.isUnlocked) {
    return window.ethereum._metamask.isUnlocked()
  }

@katspaugh katspaugh added the bug Something isn't working label Nov 13, 2022
@katspaugh katspaugh moved this to Todo in Safe{Wallet} Nov 13, 2022
@usame-algan usame-algan moved this from Todo to In Progress in Safe{Wallet} Nov 14, 2022
@usame-algan usame-algan self-assigned this Nov 14, 2022
@usame-algan usame-algan moved this from In Progress to Peer Review in Safe{Wallet} Nov 14, 2022
@usame-algan usame-algan moved this from Peer Review to Ready for QA in Safe{Wallet} Nov 14, 2022
@francovenica francovenica moved this from Ready for QA to QA in progress in Safe{Wallet} Nov 15, 2022
@francovenica francovenica moved this from QA in progress to QA done in Safe{Wallet} Nov 15, 2022
Repository owner moved this from QA done to Done in Safe{Wallet} Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants