Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check that isUnlocked exists before calling #1138

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Nov 14, 2022

What it solves

Resolves #1134

How this PR fixes it

  • Checks that the method exists before calling it

How to test

This error most likely happens with older versions of the metamask extension. It was implemented in 2018

  • Connect to the safe via MM
  • Lock the Account from MM
  • Observe the wallet disconnecting in the safe

@usame-algan usame-algan requested a review from iamacook November 14, 2022 13:28
@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 511b574
Status: ✅  Deploy successful!
Preview URL: https://c418abec.web-core.pages.dev
Branch Preview URL: https://isunlocked-error.web-core.pages.dev

View logs

@francovenica
Copy link
Contributor

Note: is said that this was more of an issue with old versions of MM, but I don't think MM let you use such an old version of its extension so it should be fine

LGTM.
Locking the MM wallet disconnects you from the app.

@usame-algan usame-algan merged commit 6dacbcd into dev Nov 15, 2022
@usame-algan usame-algan deleted the isunlocked-error branch November 15, 2022 12:45
@usame-algan usame-algan mentioned this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught exception: isUnlock is not a function
3 participants