Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieve Fallback Handler via safe-core-sdk #1236

Closed
iamacook opened this issue Nov 24, 2022 · 1 comment · Fixed by #1282
Closed

Retrieve Fallback Handler via safe-core-sdk #1236

iamacook opened this issue Nov 24, 2022 · 1 comment · Fixed by #1282
Assignees
@iamacook
Labels
enhancement New feature or request

Comments

@iamacook
Copy link
Member

What is the feature about

Now that the safe-core-sdk supports management of the Fallback Handler, we should leverage that instead of instantiating it ourselves.

The list of requirements

  • Update the safe-core-sdk to a version that supports the above.
  • Instantiate the Fallback Handler via it.
@iamacook iamacook added the enhancement New feature or request label Nov 24, 2022
@katspaugh katspaugh moved this to Todo in Safe{Wallet} Nov 25, 2022
@iamacook iamacook self-assigned this Nov 29, 2022
@iamacook iamacook mentioned this issue Nov 29, 2022
Merged
@iamacook iamacook moved this from Todo to Peer Review in Safe{Wallet} Nov 29, 2022
@iamacook iamacook moved this from Peer Review to Ready for QA in Safe{Wallet} Dec 5, 2022
@francovenica francovenica moved this from Ready for QA to QA in progress in Safe{Wallet} Dec 7, 2022
@francovenica
Copy link
Contributor

Safe creation LGTM

@francovenica francovenica moved this from QA in progress to QA done in Safe{Wallet} Dec 7, 2022
Repository owner moved this from QA done to Done in Safe{Wallet} Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamacook iamacook

Labels
enhancement New feature or request
Projects
Safe{Wallet}
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: get Compatibility Fallback Handler from SDK safe-global/safe-wallet-monorepo
2 participants
@francovenica @iamacook