Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get Compatibility Fallback Handler from SDK #1282

Merged
merged 1 commit into from
Dec 7, 2022
Merged

fix: get Compatibility Fallback Handler from SDK #1282

merged 1 commit into from
Dec 7, 2022

Conversation

iamacook
Copy link
Member

What it solves

Resolves #1236

How this PR fixes it

The Compatibility Fallback Handler is now retrieved via safe-core-sdk.

How to test it

Safe creation should function as normal.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@github-actions
Copy link

Branch preview

https://pr1282--webcore.review-web-core.5afe.dev

@iamacook iamacook merged commit 5fc780a into dev Dec 7, 2022
@iamacook iamacook deleted the compatibility-fallback-sdk branch December 7, 2022 08:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@usame-algan usame-algan usame-algan approved these changes

@germartinez germartinez Awaiting requested review from germartinez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retrieve Fallback Handler via safe-core-sdk
2 participants
@iamacook @usame-algan