Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a security warning on the Single Tx page if the tx is unsigned #898

Closed
katspaugh opened this issue Oct 12, 2022 · 1 comment · Fixed by #1067
Closed

Show a security warning on the Single Tx page if the tx is unsigned #898

katspaugh opened this issue Oct 12, 2022 · 1 comment · Fixed by #1067
Assignees
@iamacook
Labels
enhancement New feature or request

Comments

@katspaugh
Copy link
Member

What is the feature about

It's possible to propose unsigned transactions that won't appear in the queue but are still visible when opened via a direct link.

This can be potentially misused so it would be nice to display a warning that the transaction is not signed and is "untrusted".
@katspaugh katspaugh added the enhancement New feature or request label Oct 12, 2022
@iamacook iamacook self-assigned this Nov 4, 2022
@iamacook iamacook mentioned this issue Nov 4, 2022
Merged
@iamacook iamacook moved this from Todo to Peer Review in Safe{Wallet} Nov 4, 2022
@iamacook iamacook moved this to Todo in Safe{Wallet} Nov 4, 2022
@iamacook iamacook moved this from Peer Review to Ready for QA in Safe{Wallet} Nov 8, 2022
@francovenica francovenica moved this from Ready for QA to QA in progress in Safe{Wallet} Nov 9, 2022
@francovenica
Copy link
Contributor

LGTM
https://unsigned-warning.web-core.pages.dev/gor:0xF3E977e7Eea1A91ce5B2d5077e5A7195Ae18b722/transactions/tx?id=multisig_0xF3E977e7Eea1A91ce5B2d5077e5A7195Ae18b722_0xc0c5380e113ecff6054c69d02fe7d5ee753db29635548c80794bd028cf614bb5
image

@francovenica francovenica moved this from QA in progress to QA done in Safe{Wallet} Nov 9, 2022
Repository owner moved this from QA done to Done in Safe{Wallet} Nov 9, 2022
@iamacook iamacook mentioned this issue Nov 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamacook iamacook

Labels
enhancement New feature or request
Projects
Safe{Wallet}
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: unsigned warning safe-global/safe-wallet-monorepo
3 participants
@katspaugh @francovenica @iamacook