feat: unsigned warning

[iamacook]

What it solves

Resolves #898

How this PR fixes it

A new warning is shown when a proposed transaction has no signatures.

How to test it

Open /gor:0xF3E977e7Eea1A91ce5B2d5077e5A7195Ae18b722/transactions/tx?id=multisig_0xF3E977e7Eea1A91ce5B2d5077e5A7195Ae18b722_0xc0c5380e113ecff6054c69d02fe7d5ee753db29635548c80794bd028cf614bb5 and observe the warning.

Screenshots

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	d92d8e3
Status:	✅  Deploy successful!
Preview URL:	https://6fc3ecfa.web-core.pages.dev
Branch Preview URL:	https://unsigned-warning.web-core.pages.dev

View logs

[katspaugh]

IMHO this warning isn't visible enough. I would write it in big red letters above the transaction. Perhaps in an <Alert>

[katspaugh]

And text-wise, and I would write something like “This transaction is unsigned and could have been created by anyone. To avoid phishing, only sign it if you trust the source of the link.”
Perhaps too grim?

[iamacook]

IMHO this warning isn't visible enough. I would write it in big red letters above the transaction. Perhaps in an <Alert>

This follows the style of our other warnings. I'll ask design and see what they think.

Edit: @liliiaorlenko said it's ok to keep it as is for now and revisit the entire Warning implementation after "ranking" all warnings we show at a later stage.

[DiogoSoaress]

Code looks good and if this is aligned with designer 👍

I agree with this comment however

IMHO this warning isn't visible enough. I would write it in big red letters above the transaction. Perhaps in an

though an unsigned transaction can come from a friendly source, I think it would be worth to make it more prominent (as suggested) and thus not closing the issue just with this PR.

[iamacook]

I agree with this comment however

IMHO this warning isn't visible enough. I would write it in big red letters above the transaction. Perhaps in an

though an unsigned transaction can come from a friendly source, I think it would be worth to make it more prominent (as suggested) and thus not closing the issue just with this PR.

After syncing with @liliiaorlenko, we intend to document our transaction list in detail and then reassess all transaction-related notifications thereafter.

[katspaugh]

I was talking about the Single Tx page btw. The list is safe, we never load untrusted txns there. But anyone can create and share a deeplink.