fix: switching hardware wallet networks #1085
Conversation
|
|
||
| if (wallet && isHardwareWallet(wallet)) { | ||
| onboard?.disconnectWallet({ label: wallet.label }).then(() => { | ||
| connectWallet(onboard, { autoSelect: wallet.label }) |
There was a problem hiding this comment.
Note: the address scanner modal opens on Ethereum by default and you must manually select the current network. I will investigate setting this (it would need to be implemented in onboard, unless we reinitialise onboard with 1 chain configuration before connecting a hardware wallet).
Deploying with
|
| Latest commit: |
5ad9f7d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4a4afd68.web-core.pages.dev |
| Branch Preview URL: | https://hw-wallet-network-switch.web-core.pages.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
@francovenica please test this with Keystone as well. |
I don't have a keystone (those are illegal in Argentina :D ). @liliya-soroka I think you have one |
|
I tried both with trezor one and ledger NanoS and in both cases the connection persisted while changing networks.
|
|
Miss understood the moment were it disconnects. You actually have to click "Change to NETWORK" for the disconnect to happen, which is correct. So disregard my last comment |
|
I've checked that the onboard doesn't allow the user to connect the device to a network where is not compatible. Example: connection to ETH with trezor, then switching to aurora and clicking the button "Switch to Aurora" shows an error message in the onboard, which is the correct behavior |
|
LGTM |
What it solves
Resolves #1073
How this PR fixes it
If a hardware wallet is connected, it is diconnected and reconnected when switching network as it is not possible to change the network of a hardware wallet.
How to test it
Open the Safe on a network where a Ledger/Trezor is enabled and connect it. Switch to another network that also supports Ledger/Trezor. Observe the address scanner modal open.