fix: redirect to old deployment for legacy Safes #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Deploying with
|
| Latest commit: |
3af7c7d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d19ea1dd.web-core.pages.dev |
| Branch Preview URL: | https://update-redirect.web-core.pages.dev |
DiogoSoaress
approved these changes
Nov 8, 2022
| @@ -37,6 +39,7 @@ describe('useSafeNotifications', () => { | |||
| implementation: { value: '0x123' }, | |||
| implementationVersionState: 'OUTDATED', | |||
| version: '1.1.1', | |||
| chainId: '1', | |||
katspaugh
requested changes
Nov 8, 2022
src/hooks/useSafeNotifications.ts
Outdated
| href: { | ||
| link: { | ||
| href: isOldSafe | ||
| ? `https://gnosis-safe.io/app/${chain?.shortName}:${safeAddress}/settings/details?no-redirect=true` |
There was a problem hiding this comment.
Please make the old URL a constant. The safe query param can be taken from the router instead of concatenating chainId and safeAddress.
katspaugh
reviewed
Nov 8, 2022
src/hooks/useSafeNotifications.ts
Outdated
| }), | ||
| ) | ||
|
|
||
| return () => { | ||
| dispatch(closeNotification({ id })) | ||
| } | ||
| }, [dispatch, implementationVersionState, version, query.safe]) | ||
| }, [dispatch, implementationVersionState, version, query.safe, safeAddress]) |
There was a problem hiding this comment.
safeAddress can be removed now.
|
Tested, and it works. ✅ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Notification link for legacy Safes
How this PR fixes it
Instead of linking to the CLI, we link to the upgrade page of the
safe-reactdeployment for older Safes not supported byweb-core.How to test it
Open a <1.1.1 Safe and observe the new link in the notification.
Note: redirection on
safe-reactwill still happen until we merge this.