test: spy and wait for slow network requests #1107
Conversation
Deploying with
|
| Latest commit: |
b55f85f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8f823531.web-core.pages.dev |
| Branch Preview URL: | https://e2e-stub-estimation.web-core.pages.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
| // Alias for New transaction modal | ||
| cy.contains('h2', 'Review transaction').parents('div').as('modal') | ||
|
|
||
| // Wait for /estimations response | ||
| cy.wait('@estimations') |
There was a problem hiding this comment.
Instead of waiting for the real request, I've also considered stubbing the first request by using Date.now() for the recommended nonce. This way we wouldn't have to hit the server with any /estimations request at all and we'd guarantee the nonce is never repeated.
It would make the test more robust but it felt like an overkill. WDYT?
There was a problem hiding this comment.
IMHO e2e tests should not stub anything.
There was a problem hiding this comment.
I've changed it. Only spy on the request now
DiogoSoaress
changed the title
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Safe Web Core Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
What it solves
Broken
create_txE2E test in the CIHow this PR fixes it
Spy and wait for the
/estimationsnetwork requestStub the second
/estimationsrequestSpy and wait for the
/proposenetwork request