fix: "Aborting fetching component for router" #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
6273c87
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1d760eb6.web-core.pages.dev |
| Branch Preview URL: | https://fix-router-error.web-core.pages.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
schmanu
approved these changes
Nov 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #1112
How this PR fixes it
As we don't want to interact with the DOM,
useLayoutEffectremoved the error (which was caused by callingrouter.replacetoo many times).How to test it
Open
/and observe no error in the console. Navigating to the following should work as before:?safe=xyz:0x123?chain=xyz(no added Safe)/welcome