fix: Safe Apps list styles issues #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix action buttons space
dasanra
changed the title
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Deploying with
|
| Latest commit: |
4dbc87a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b743a699.web-core.pages.dev |
| Branch Preview URL: | https://fix-styles-issues.web-core.pages.dev |
iamacook
approved these changes
Nov 9, 2022
|
Looking sharp, thanks! Tried in several browsers (chrome, firefox, brave and safari), different resolutions & mobile mode and I did not experience any visual issues 👍 |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Safe Web Core Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves styling issues mainly affecting the Safe Apps list.
It also includes tweaks to some generic rules as the border radius for buttons and container elements.
How this PR fixes it
Update styles on Safe Apps list to follow design guidelines
https://www.figma.com/file/ptTs6lDBeUuLNySroJ5PiF/Web-Master-File?node-id=1%3A7
Update generic styles to follow design guidelines
https://www.figma.com/file/HKW5iarMST9rL7Kxkf59qY/MUI-for-Figma?node-id=10838%3A66318
Screenshots
Before
After
