Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Store newly created safe #1128

Merged
merged 1 commit into from
Nov 11, 2022
Merged

fix: Store newly created safe #1128

merged 1 commit into from
Nov 11, 2022

Conversation

usame-algan
Copy link
Member

What it solves

Resolves #1121

How this PR fixes it

We were using pendingSafe.address instead of pendingSafe.safeAddress. I opted against refactoring the types to keep this PR small but added a TODO.

How to test it

  1. Create a new safe
  2. Observe that it is being added to the added safes list

@usame-algan usame-algan requested a review from iamacook November 10, 2022 12:20
@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bb4a7c1
Status: ✅  Deploy successful!
Preview URL: https://0515a48d.web-core.pages.dev
Branch Preview URL: https://create-safe-add-entry.web-core.pages.dev

View logs

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@usame-algan usame-algan merged commit 95a804b into dev Nov 11, 2022
@usame-algan usame-algan deleted the create-safe-add-entry branch November 11, 2022 12:16
@usame-algan usame-algan mentioned this pull request Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sidebar] - Created safe shows with undefined address
3 participants