Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: improve reliability of create_tx cypress test #1196

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Nov 18, 2022

What it solves

Changes how we wait for intercepted requests.
The propose request timed out a lot of times.

@schmanu schmanu requested a review from iamacook November 18, 2022 10:07
@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cd08a75
Status: ✅  Deploy successful!
Preview URL: https://317de083.web-core.pages.dev
Branch Preview URL: https://improve-create-tx-cypress.web-core.pages.dev

View logs

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the job again and it works nicely.

@katspaugh katspaugh changed the title improve reliability of create_tx cypress test e2e: improve reliability of create_tx cypress test Nov 22, 2022
@katspaugh katspaugh merged commit 19b5e8f into dev Nov 22, 2022
@katspaugh katspaugh deleted the improve-create-tx-cypress branch November 22, 2022 10:48
@katspaugh katspaugh mentioned this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants