feat: redesign (external) links #1241
Conversation
ESLint Summary View Full Report
Report generated by eslint-plus-action |
| @@ -488,7 +488,7 @@ const initTheme = (darkMode: boolean) => { | |||
| MuiLink: { | |||
| styleOverrides: { | |||
| root: ({ theme }) => ({ | |||
| textDecoration: 'none', | |||
There was a problem hiding this comment.
I talked about this change with lila
Branch preview |
| target="_blank" | ||
| sx={{ textDecoration: 'none' }} | ||
| > | ||
| <ExternalLink href="https://safe.global/terms" sx={{ textDecoration: 'none' }}> |
There was a problem hiding this comment.
Should we remove the textDecoration now?
|
Does this also resolve #1231 or are there gnosis-safe.io links left? |
It should at least I searched for gnosis-safe.io and tried to update all links which should point to safe.global. I left some urls which are pointing to the old app on purpose. I'll edit the PR description. Didnt see that issue :) |
| * It also always adds the external link icon as end adornment. | ||
| */ | ||
| const ExternalLink = ({ | ||
| suppressIcon = false, |
There was a problem hiding this comment.
nit: I would name this hideIcon for brevity
|
In the old Safe creation flow the links of terms of privacy and policy don't have the new link format. I don't have the new safe creation flow in this PR. can you check if there they have the proper format? if they have then I can close this ticket |
Branch preview✅ Deploy successful! https://redesign-external-links--webcore.review-web-core.5afe.dev |
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
Hey @francovenica, I merged dev into this branch and fixed multiple links in the old and new safe creation to use the new ExternalLink component. Good catch. Btw in the old safe creation those two links you found did not even link to any pages. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Looks good. |
What it solves
Links look the same as normal text making it hard to see what is a clickable link and what is just text.
Resolves #1174 , #1231
How this PR fixes it
ExternalLinkcomponent which is similar to Link but always sets a securerelattribute, the target to_blankand by default appends an external-link icon.gnosis-safe.iolinks bysafe.global. For instance links to help articles, policies, etc.How to test it
Check the various external links in our interface:
Analytics changes
None
Screenshots