Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Send current step with tracking event #1249

Merged
merged 1 commit into from
Nov 25, 2022
Merged

fix: Send current step with tracking event #1249

merged 1 commit into from
Nov 25, 2022

Conversation

usame-algan
Copy link
Member

What it solves

Resolves #1248

How this PR fixes it

  • Adds the current step as label to the tracked event

How to test it

  1. Open the safe creation
  2. Click Next
  3. Observe that the GTM event in the console contains the current step as label

@usame-algan usame-algan requested a review from iamacook November 25, 2022 09:42
@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@github-actions
Copy link

Branch preview

https://pr1249--webcore.review-react-br.5afe.dev

katspaugh
katspaugh approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@usame-algan usame-algan merged commit 243ad59 into dev Nov 25, 2022
@usame-algan usame-algan deleted the fix-stepper-tracking branch November 25, 2022 14:06
@katspaugh katspaugh mentioned this pull request Nov 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamacook iamacook iamacook approved these changes

@katspaugh katspaugh katspaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stepper is not tracking current step
3 participants
@usame-algan @katspaugh @iamacook