Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert accordion transitions #1304

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Conversation

usame-algan
Copy link
Member

What it solves

Reverts #1064

Also added an enhancement issue to look at this again in the future #1303

How this PR fixes it

How to test it

  • Open the Transaction history/queue
  • Observe that there are no network requests for tx details
  • Open a transaction accordion
  • Observe that there is one network request for its details

@usame-algan usame-algan requested a review from iamacook December 2, 2022 09:40
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Branch preview

✅ Deploy successful!

https://revert-accordion-mount--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

The revert looks fine. Just loading the tx list doesn't make a multisig call for every tx anymore

Note: I've noticed that a multisig call is done every time you open a tx details, even if you opened it before. We are going to fix that in this ticket #1303
multisig call

@usame-algan usame-algan merged commit 7c24ed4 into dev Dec 6, 2022
@usame-algan usame-algan deleted the revert-accordion-mount branch December 6, 2022 15:09
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants