Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow resetting to recommended nonce of 0 #1329

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Dec 8, 2022

What it solves

Resolves #1311

How this PR fixes it

The typeof recommendedNonce is checked that it is a 'number' instead of whether it is truthy.

How to test it

  1. Create a new Safe and create a new transaction.
  2. Edit the nonce to >0 and reset the nonce to the recommended value.
  3. Observe that it sets to 0.

Screenshots

recommended nonce

@iamacook iamacook requested a review from schmanu December 8, 2022 11:38
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Branch preview

✅ Deploy successful!

https://recommended-nonce--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh
Copy link
Member

Verified, it resets to zero. ✅

Screenshot 2022-12-09 at 08 17 49

@katspaugh katspaugh merged commit 3fd349d into dev Dec 9, 2022
@katspaugh katspaugh deleted the recommended-nonce branch December 9, 2022 07:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Advanced Parameters] Recomended nonce button doesn't work for nonce = 0
3 participants