Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change status colors in safe creation #1339

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Conversation

usame-algan
Copy link
Member

What it solves

Resolves #1299

How this PR fixes it

  • Error color on the status screen is now red instead of green
  • Every other status is now colored blue instead of orange

How to test it

  1. Open the new safe creation flow
  2. Submit the form
  3. Observe a blue status message
  4. Reject the transaction
  5. Observe a red status message

Screenshots

Screenshot 2022-12-09 at 12 20 46

Screenshot 2022-12-09 at 12 20 42

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Branch preview

✅ Deploy successful!

https://fix-status-color--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh
Copy link
Member

Verified, looks much better! ✅

@katspaugh katspaugh merged commit e24c7fe into dev Dec 9, 2022
@katspaugh katspaugh deleted the fix-status-color branch December 9, 2022 11:43
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Safe creation] Info and error alerts have wrong colors
4 participants