Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase font-size for EthHashInfo #1359

Merged
merged 1 commit into from
Dec 16, 2022
Merged

fix: Increase font-size for EthHashInfo #1359

merged 1 commit into from
Dec 16, 2022

Conversation

usame-algan
Copy link
Member

What it solves

Resolves #1242

How this PR fixes it

  • Changes the font-size of EthHashInfo addresses to inherit (16px)
  • (refactor): Extracts the recipient area from tx modals into SendToBlock to keep the smaller font-size of 14px for all addresses displayed inside tx modals. Also addresses some inconsistencies across different tx modals where captions had different colors and font-weights.

How to test it

  1. Open a safe
  2. Go to History
  3. Open a transaction
  4. Observe all addresses and hashes have the same font-size
  5. Open a tx modal
  6. Observe that all addresses have a smaller font-size of 14px

Screenshots

Screenshot 2022-12-13 at 12 44 40

Screenshot 2022-12-13 at 12 46 32

@github-actions
Copy link

github-actions bot commented Dec 13, 2022

Branch preview

✅ Deploy successful!

https://fixaddresssize--webcore.review-web-core.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@liliya-soroka
Copy link
Member

Verified

@usame-algan usame-algan merged commit 1b3a0b6 into dev Dec 16, 2022
@usame-algan usame-algan deleted the fix-address-size branch December 16, 2022 10:03
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addresses and hash properties is smaller size then other text
3 participants