-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: display factory and mastercopy known names in create tx info #1365
Conversation
Branch preview✅ Deploy successful! https://fix_known_addr_safe_creation--webcore.review-web-core.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that these are "known addresses" on all networks? Afaiu, these need to have been manually named on the infra side.
If the name is not know by the transaction services, it will display the one from AB or none. |
It won't show anything if there is no |
If they are not known (not answered by the services) we simply don't display the Address name. How do you think it should behave? From my tests across networks they are always present. |
Your example from Do we want to keep this logic and show the title with a pre-defined "empty state" or just hide them entirely? There is no design reference for this. cc @liliiaorlenko |
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Safe Web Core Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
What it solves
Resolves #1347
How this PR fixes it
Passes mastercopy and factory known address names to the CreationTxInfo elements
How to test it
Expand a create tx info
(
eth:0x92Db8FF884Fd2872888a61244FAEB1C50bf10cc3/transactions/history
)Screenshots