Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: take native number validation into account #1368

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Dec 14, 2022

What it solves

Resolves #1353

How this PR fixes it

NumberField has been reverted to normal type. We can reapproach this here.

How to test it

Enter erroneous values into the following fields, especially thousand separators:

  • Spending limit amount
  • Transaction filter
    • Amount
    • Nonce
  • Send assets
    • Amount
    • Advanced parameters
      • Safe nonce
      • Wallet nonce
      • safeTxGas
      • maxPriorityFeePerGas
      • maxFeePerGas
      • Gas limit

Screenshots

validation2

@iamacook iamacook requested a review from usame-algan December 14, 2022 09:52
@iamacook iamacook self-assigned this Dec 14, 2022
@github-actions
Copy link

github-actions bot commented Dec 14, 2022

Branch preview

✅ Deploy successful!

https://numbervalidation--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Dec 14, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@liliya-soroka
Copy link
Member

Verified

@iamacook iamacook merged commit 7e45176 into dev Dec 14, 2022
@iamacook iamacook deleted the number-validation branch December 14, 2022 12:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1. Text is displayed inside amount field
3 participants