fix: Allow editing gas fees for spending limit transactions #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! https://fixspendinglimitgas--webcore.review-web-core.5afe.dev |
usame-algan
commented
Dec 14, 2022
| Safe transaction | ||
| </Typography> | ||
| </Grid> | ||
| {(params.nonce !== undefined || !!params.safeTxGas) && ( |
There was a problem hiding this comment.
Added this condition so that the title is only shown if there is either a nonce or safeTxGas field
ESLint Summary View Full Report
Report generated by eslint-plus-action |
iamacook
approved these changes
Dec 14, 2022
|
Can confirm that it is now possible to edit the transaction details of spending limit transactions.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #1345
How this PR fixes it
How to test it
Screenshots