Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use break-word #1375

Merged
merged 2 commits into from
Dec 19, 2022
Merged

fix: use break-word #1375

merged 2 commits into from
Dec 19, 2022

Conversation

DiogoSoaress
Copy link
Member

What it solves

Resolves #1277

How this PR fixes it

Uses word-break: break-word for the error details message

How to test it

Follow #1277 steps

Screenshots

Screenshot 2022-12-14 at 17 04 57

Screenshot 2022-12-14 at 17 04 39

@github-actions
Copy link

github-actions bot commented Dec 14, 2022

Branch preview

✅ Deploy successful!

https://fix_error_message_wrap--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Dec 14, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh
Copy link
Member

Verified, looks good.

Screenshot 2022-12-19 at 10 16 22

@katspaugh katspaugh merged commit 6dd6c0a into dev Dec 19, 2022
@katspaugh katspaugh deleted the fix-error-message-wrap branch December 19, 2022 09:16
@gitpoap-bot
Copy link

gitpoap-bot bot commented Dec 19, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Safe Web Core Contributor:

GitPOAP: 2022 Safe Web Core Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the text in the error message when the tx will most likely fail
3 participants