chore: added Dockerfile #1390
Merged
chore: added Dockerfile #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! https://feat_added_dockerfile--webcore.review-web-core.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
reviewed
Dec 17, 2022
Dockerfile
Outdated
|
|
||
| ENV NODE_ENV production | ||
| # Uncomment the following line in case you want to disable telemetry during runtime. | ||
| ENV NEXT_TELEMETRY_DISABLED 1 |
There was a problem hiding this comment.
yep it seems that its needed, I used this repo as a template because its recommended in the nextjs docs
There was a problem hiding this comment.
I mean it's already set on line 13 and we don't call any Next scripts after this.
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Safe Web Core Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Added
Dockerfileto Resolve safe-global/safe-infrastructure#58How this PR fixes it
based in this template recommended in the nextjs docs
Added a
DockerfilefileHow to test it
To test the image run:
docker build -t web-core .docker run -p 3000:3000 web-corehttp://127.0.0.1:3000