Fix: psa banner fixed on top #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
usame-algan
reviewed
Dec 19, 2022
katspaugh
force-pushed
the
fix-banner
branch
from
8342590 to
3d2676a
Compare
|
There is an issue on the Transaction page when scrolling down, the navbar is only half-visible. I think we need to use the header-height var there too. |
|
@usame-algan good catch, I've adjusted the PageHeader to use the global var as well. |
usame-algan
approved these changes
Dec 20, 2022
|
How many rows of text is the average for this banners? When there are 3 lines or more it start to "eat" the page |
|
The text is currently hardcoded, so 1 line. |
|
Ok then. Looks good to me |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #1202
How this PR fixes it
The banner is now statically positioned on top of the header. When it's opened, the global header-height variable is set to 104px. When it's closed, it's set back to 52px.