Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Keyboard support #1454

Merged
merged 4 commits into from
Jan 5, 2023
Merged

fix: Keyboard support #1454

merged 4 commits into from
Jan 5, 2023

Conversation

usame-algan
Copy link
Member

What it solves

Resolves #1450

How this PR fixes it

  • Shows hidden buttons when they are focused
  • Fixes the Tab Navigation keyboard support
  • Removes redundant links on the dashboard
  • Disables keyboard support for safe app images that are embedded via iframe
  • Only renders advanced details for transactions if its expanded

How to test it

  1. Open the Safe
  2. Tab through the dashboard
  3. Observe that each clickable element is only focused once
  4. Navigate to the assets page
  5. Tab through the page
  6. Observe the Send buttons are visible on focus
  7. Observe the Tab Navigation at the top of the page is usable via keyboard (arrow keys)
  8. Navigate to the NFT Page
  9. Observe that the Send Button is visible on focus
  10. Navigate to the History
  11. Tab through a transaction
  12. Observe that advanced details are ignored in the tab order if they are not expanded

@github-actions
Copy link

github-actions bot commented Dec 23, 2022

Branch preview

✅ Deploy successful!

https://fix_tab_elements--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Dec 23, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@DiogoSoaress DiogoSoaress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francovenica
Copy link
Contributor

Navigation itself looks good, I can reach the whole site with it and with that the ticket would be fine to pass. I didn't found places where tabbing would select the same item twice.

@usame-algan usame-algan merged commit ad11abb into dev Jan 5, 2023
@usame-algan usame-algan deleted the fix-tab-elements branch January 5, 2023 10:25
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing keyboard support for some elements
4 participants