fix: update signers confirmations

[DiogoSoaress]

What it solves

Resolves #1374

How this PR fixes it

Adds txQueuedTag to the dependency array to fetch TransactionDetails

How to test it

1. Create a queued transaction in a Safe with a threshold greater than 1
2. Expand the transaction in the queue so that TxSigners is visible
3. Add a confirmation and observe the TxSigners displaying the new data

Analytics changes

N/A

Screenshots

[github-actions]

Branch preview

✅ Deploy successful!

https://fix_update_tx_signers_confirmations--webcore.review-web-core.5afe.dev

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[schmanu]

I think we should align the way we refresh our TxDetails with how we do it for SingleTx.

Otherwise for SingleTxs we would refresh twice for instance.

[schmanu]

I would not put this so deep into the TxSigners component.
I think we should refresh and display the entire Transaction details correctly (In the TxDetails component).

Currently it only refreshed the right side (txSigners) but the signatures are also listed in the advanced details on the left side.

[schmanu]

In the TxDetails we already have a bunch of conditions under which we will refresh the details. I would just add the txQueuedTag and txHistoryTag to that array:

const TxDetails = ({
  txSummary,
  txDetails,
}: {
  txSummary: TransactionSummary
  txDetails?: TransactionDetails // optional
}): ReactElement => {
  const chainId = useChainId()
  const { safe } = useSafeInfo()

  const [txDetailsData, error, loading] = useAsync<TransactionDetails>(async () => {
    return txDetails || getTransactionDetails(chainId, txSummary.id)
  }, [txDetails, chainId, txSummary.id, safe.txQueuedTag, safe.txHistoryTag])

// ...
}

That is how we also refresh the tx details for a singleTx in the SingleTx too.

[DiogoSoaress]

oh I didn't think about the tags! I'm going to give it a try

[DiogoSoaress]

I've implemented this way. Thank you for the valuable input!

[schmanu]

Looks good! At some point we could add a test to the TxDetails I guess :)

[francovenica]

I'd prefer it without having it without collapsing and re expanding, but is good and works fine

[DiogoSoaress]

I'd prefer it without having it without collapsing and re expanding, but is good and works fine

I also didn't like that it was collapsing but we have a rule to collapse it when:

• the nr of confirmations matches the threshold

meaning that is happening because you're testing a 2/N Safe.

Alternatively we could remove that condition but I'd prefer having that decision coming from design.

Edit:
with the last push it won't collapse / expand the accordion no more and neither the confirmations stepper.

You can recheck it @francovenica 🙌

[francovenica]

Yes. the collapse is not happening anymore, it just reloads the tx description seemsly