Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger validation upon owner removal #1477

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Conversation

DiogoSoaress
Copy link
Member

What it solves

Resolves #1350

How this PR fixes it

Triggers a form validation after an owners array change

How to test it

In the creation flow, add a repeated owner.
Remove the repeated owner.
The form should have no errors.

Analytics changes

Screenshots

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

Branch preview

✅ Deploy successful!

https://fix_repeated_owner_error--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that we have validation mode: 'all' for the owner step and it seems to run the validation twice as much as needed. I believe changing it to onChange would suffice.

src/components/new-safe/create/steps/Step2/index.tsx Outdated Show resolved Hide resolved
@francovenica
Copy link
Contributor

LGTM

@katspaugh katspaugh merged commit 390d780 into dev Jan 9, 2023
@katspaugh katspaugh deleted the fix-repeated-owner-error branch January 9, 2023 08:05
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Create safe] Repeated owner error not disappearing until focus is done
4 participants