Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't show unread badge if showing all #1488

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Jan 5, 2023

What it solves

Resolves #1487

How this PR fixes it

The unread badge is hidden if showing all notifications (when there are more unread notifications than the notification limit).

How to test it

  1. Queue >4 notifcations, without reading them.
  2. Open the notification centre and observe an unread badge on the expand button.
  3. Expand the list and no longer observe an unread badge.
  4. Hiding again (without having read the later notifications) should display the unread badge again.

Screenshots

unread badge

@iamacook iamacook requested a review from katspaugh January 5, 2023 14:24
@iamacook iamacook assigned iamacook and unassigned iamacook Jan 5, 2023
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Branch preview

✅ Deploy successful!

https://notification_badge--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. In the future, please keep "good first issues" for external contributors.

@katspaugh katspaugh merged commit fe45b06 into dev Jan 5, 2023
@katspaugh katspaugh deleted the notification-badge branch January 5, 2023 14:42
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Notification Center] Green badge on the Hide button
2 participants