Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asset table rerender #1491

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Jan 5, 2023

Note: I based this branch off spam-tokens-manually-hide as the EnhancedTable is refactored there in a way necessary to fix this!

What it solves

Render problems when sorting assets.

Resolves #1482

How this PR fixes it

  • Adds a meaningful key to each asset row instead of the index.

How to test it

  • Sort the assets and witness the logos to be updated.

Analytics changes

None

@schmanu schmanu changed the base branch from dev to spam-tokens-manually-hide January 5, 2023 15:00
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Branch preview

✅ Deploy successful!

https://fix_asset_table_rerender--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@schmanu schmanu requested a review from usame-algan January 5, 2023 15:02
@katspaugh katspaugh merged commit 3ee704c into spam-tokens-manually-hide Jan 9, 2023
@katspaugh katspaugh deleted the fix-asset-table-rerender branch January 9, 2023 08:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2023
@francovenica
Copy link
Contributor

Already merged, Still I gave it a look and it works fine. Also I think this was merged into the hiden tokens ticket

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Safe assets] Default icons for tokens are shown after sorting the table
3 participants