Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add PWA fields in the manifest #1499

Merged
merged 4 commits into from
Jan 9, 2023
Merged

Fix: add PWA fields in the manifest #1499

merged 4 commits into from
Jan 9, 2023

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Jan 9, 2023 •
edited
Loading

What it solves

According to MDN, the correct extension is .webmanifest, and it needs start_url for the PWA to be installable.

Also updated the desktop icons from the brand figma.

Screenshot 2023-01-09 at 10 44 23

@github-actions
Copy link

github-actions bot commented Jan 9, 2023 •
edited
Loading

Branch preview

✅ Deploy successful!

https://manifest--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Jan 9, 2023 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@katspaugh katspaugh requested a review from DiogoSoaress January 9, 2023 09:51
DiogoSoaress
DiogoSoaress approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@DiogoSoaress DiogoSoaress left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I could test it in the deployment URL but not if running the branch locally. Do you know why?

@katspaugh
Copy link
Member Author

Because https.

@katspaugh katspaugh merged commit 439d586 into dev Jan 9, 2023
@katspaugh katspaugh deleted the manifest branch January 9, 2023 10:21
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2023
@liliya-soroka
Copy link
Member

the corners of the app icon is not rounded
image

@katspaugh
Copy link
Member Author

Good catch, I missed that one. Fixed here: #1526

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DiogoSoaress DiogoSoaress DiogoSoaress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Safe{Wallet}
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katspaugh @liliya-soroka @DiogoSoaress