Refactor: useRecommendedNonce + useSafeTxGas #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview❌ Deploy failed! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
usame-algan
reviewed
Jun 1, 2023
katspaugh
force-pushed
the
use-recommended-nonce
branch
from
b21bc7b to
e1c7985
Compare
katspaugh
force-pushed
the
use-recommended-nonce
branch
from
e1c7985 to
630dbeb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useRecommendedNonce is now decoupled from safeTxGas estimation. It just looks up the last item in the queue or the Safe nonce.