feat: Change threshold flow #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! https://change_threshold_flow--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
reviewed
Jun 13, 2023
| @@ -34,7 +34,7 @@ const SignOrExecuteForm = (props: SignOrExecuteProps): ReactElement => { | |||
| const willExecute = (props.onlyExecute || shouldExecute) && canExecute | |||
|
|
|||
| // Estimate gas limit | |||
| const { gasLimit, gasLimitError } = useGasLimit(safeTx) | |||
| const { gasLimit, gasLimitError } = useGasLimit(willExecute ? safeTx : undefined) | |||
There was a problem hiding this comment.
Why this change? Gas limit is needed for simulation. If it's only estimated for executions, it should be moved to the ExecuteForm.
There was a problem hiding this comment.
This was a regression when we refactored this component. Moving it into the ExecuteForm would make the Simulation always fetch the latest block gas limit which is less accurate so I would suggest keeping it here for now.
katspaugh
approved these changes
Jun 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Part of #2067
How this PR fixes it
How to test it
Screenshots
Checklist