Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update flow #2089

Merged
merged 1 commit into from
Jun 13, 2023
Merged

feat: update flow #2089

merged 1 commit into from
Jun 13, 2023

Conversation

iamacook
Copy link
Member

What it solves

Migrating the update Safe flow to the new transaction flow framework.

How this PR fixes it

The update Safe flow has been ported, as well as removing the old one.

How to test it

Update the Safe via the settings and observe a successful transaction.

Screenshots

update flow

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from katspaugh June 13, 2023 14:06
@iamacook iamacook self-assigned this Jun 13, 2023
@github-actions
Copy link

github-actions bot commented Jun 13, 2023

Branch preview

✅ Deploy successful!

https://update_flow--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦾

@iamacook iamacook merged commit 5b5c261 into epic-tx-flow Jun 13, 2023
@iamacook iamacook deleted the update-flow branch June 13, 2023 14:25
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants