Onclose callback #2094
Merged
Onclose callback #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
usame-algan
approved these changes
Jun 14, 2023
| @@ -85,7 +84,7 @@ const NewModalDialog = ({ | |||
| <span style={{ flex: 1 }} /> | |||
| <IconButton | |||
| aria-label="close" | |||
| onClick={() => setTxFlow(undefined)} | |||
| onClick={(e) => onClose?.(e, 'backdropClick')} | |||
There was a problem hiding this comment.
Do we have to call onClose with e and backdropClick here even if its not being used?
There was a problem hiding this comment.
Yeah, that's the signature of that prop inherited from the MUI Dialog.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user closes the tx modal by clicking on the X button, or navigating to another route, the current Safe Apps transaction should be cancelled.