-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TX flow] Batch execute fixes #2268
Conversation
Branch preview⏳ Deploying a preview site... |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good but I'm not sure about entirely hiding the status widget. Perhaps we should just hide the irrelevant steps. What do you think?
I was also thinking about that but the only relevant step is "Execute" which we already tell the user in the subtitle by saying "Execute Batch". |
It seems odd without the widget as it doesn't "match" the flow. We could still show the "Execute" step. cc @liliiaorlenko (see screenshot in description) |
yes I would still keep the execute step for sure, it makes sense in overall structure of transaction flow |
…status messages for batch execution
I've updated the status widget messages (see PR description). |
What it solves
Part of #2067
How this PR fixes it
How to test it
Screenshots
Checklist