Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Align decoded tx ui for batch execute #2275

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Jul 11, 2023

What it solves

Part of #2067

How this PR fixes it

  • Adds Expand/Collapse all buttons to batch execute
  • Renames Batch execute submit button to "Submit"
  • Doesn't show the confirm dialog when batch executing

Other fixes

  • Updates the spending limit components to use SendAmountBlock instead of AmountBlock since it supports a custom title now and is more in line with the rest of the layout

How to test it

  1. Open a Safe
  2. Queue and confirm at least 2 transactions
  3. Press Execute Batch
  4. Observe the decoded tx ui with buttons

Screenshots

Screenshot 2023-07-11 at 17 04 50

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@usame-algan usame-algan requested a review from iamacook July 11, 2023 15:06
@github-actions
Copy link

github-actions bot commented Jul 11, 2023

Branch preview

✅ Deploy successful!

https://decoded_txs--walletweb.review-wallet-web.5afe.dev

Comment on lines +19 to +21
<>
<MultisendActionsHeader title="Batched transactions" setOpen={setOpenMap} amount={txs.length} compact />

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some duplication between this and the Multisend component because of the data type difference but I suggest we refactor it as a future task.

@github-actions
Copy link

github-actions bot commented Jul 11, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan usame-algan merged commit f487649 into epic-tx-flow Jul 11, 2023
@usame-algan usame-algan deleted the decoded-txs branch July 11, 2023 15:29
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants