Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get Safe address on-chain for ZK creations #2416

Merged
merged 7 commits into from
Aug 18, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/new-safe/create/steps/ReviewStep/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import classnames from 'classnames'
import { hasRemainingRelays } from '@/utils/relaying'
import { BigNumber } from 'ethers'
import { usePendingSafe } from '../StatusStep/usePendingSafe'
import { useIsZkEvmChain } from '../StatusStep/useIsZkEvmChain'

const ReviewStep = ({ data, onSubmit, onBack, setStep }: StepRenderProps<NewSafeFormData>) => {
const isWrongChain = useIsWrongChain()
Expand All @@ -37,6 +38,7 @@ const ReviewStep = ({ data, onSubmit, onBack, setStep }: StepRenderProps<NewSafe
const saltNonce = useMemo(() => Date.now(), [])
const [_, setPendingSafe] = usePendingSafe()
const [executionMethod, setExecutionMethod] = useState(ExecutionMethod.RELAY)
const isZkEvmChain = useIsZkEvmChain()

const ownerAddresses = useMemo(() => data.owners.map((owner) => owner.address), [data.owners])
const [minRelays] = useLeastRemainingRelays(ownerAddresses)
Expand Down Expand Up @@ -91,7 +93,7 @@ const ReviewStep = ({ data, onSubmit, onBack, setStep }: StepRenderProps<NewSafe
},
}

const safeAddress = await computeNewSafeAddress(provider, props)
const safeAddress = isZkEvmChain ? undefined : await computeNewSafeAddress(provider, props)

const pendingSafe = {
...data,
Expand Down
86 changes: 64 additions & 22 deletions src/components/new-safe/create/steps/StatusStep/StatusStepper.tsx
Original file line number Diff line number Diff line change
@@ -1,40 +1,82 @@
import { Box, Step, StepConnector, Stepper, Typography } from '@mui/material'
import { useEffect } from 'react'
import css from '@/components/new-safe/create/steps/StatusStep/styles.module.css'
import EthHashInfo from '@/components/common/EthHashInfo'
import { SafeCreationStatus } from '@/components/new-safe/create/steps/StatusStep/useSafeCreation'
import StatusStep from '@/components/new-safe/create/steps/StatusStep/StatusStep'
import { usePendingSafe } from './usePendingSafe'
import { useIsZkEvmChain } from './useIsZkEvmChain'
import { useWeb3ReadOnly } from '@/hooks/wallets/web3'

// TODO: Remove when we update SDK
const useSyncZkEvmSafeAddress = (status: SafeCreationStatus) => {
iamacook marked this conversation as resolved.
Show resolved Hide resolved
const isZkEvmChain = useIsZkEvmChain()
const [pendingSafe, setPendingSafe] = usePendingSafe()
const web3ReadOnly = useWeb3ReadOnly()

useEffect(() => {
if (
!isZkEvmChain ||
status !== SafeCreationStatus.SUCCESS ||
!pendingSafe ||
!pendingSafe.txHash ||
iamacook marked this conversation as resolved.
Show resolved Hide resolved
pendingSafe.safeAddress ||
!web3ReadOnly
) {
return
}

let isCurrent = true

web3ReadOnly
.getTransactionReceipt(pendingSafe.txHash)
.then((receipt) => {
if (isCurrent) {
const safeAddress = receipt.logs[0].address
iamacook marked this conversation as resolved.
Show resolved Hide resolved
setPendingSafe(pendingSafe ? { ...pendingSafe, safeAddress } : undefined)
}
})
.catch(() => null)

return () => {
isCurrent = false
}
}, [status, web3ReadOnly, pendingSafe, pendingSafe?.txHash, pendingSafe?.safeAddress, isZkEvmChain, setPendingSafe])
}

const StatusStepper = ({ status }: { status: SafeCreationStatus }) => {
const [pendingSafe] = usePendingSafe()
if (!pendingSafe?.safeAddress) return null

useSyncZkEvmSafeAddress(status)

return (
<Stepper orientation="vertical" nonLinear connector={<StepConnector className={css.connector} />}>
{pendingSafe?.safeAddress && (
<Step>
<StatusStep isLoading={!pendingSafe.safeAddress} safeAddress={pendingSafe.safeAddress}>
<Box>
<Typography variant="body2" fontWeight="700">
Your Safe Account address
</Typography>
<EthHashInfo
address={pendingSafe.safeAddress}
hasExplorer
showCopyButton
showName={false}
shortAddress={false}
showAvatar={false}
/>
</Box>
</StatusStep>
</Step>
)}
<Step>
<StatusStep isLoading={!pendingSafe.safeAddress} safeAddress={pendingSafe.safeAddress}>
<Box>
<Typography variant="body2" fontWeight="700">
Your Safe Account address
</Typography>
<EthHashInfo
address={pendingSafe.safeAddress}
hasExplorer
showCopyButton
showName={false}
shortAddress={false}
showAvatar={false}
/>
</Box>
</StatusStep>
</Step>
<Step>
<StatusStep isLoading={!(pendingSafe.txHash || pendingSafe.taskId)} safeAddress={pendingSafe.safeAddress}>
<StatusStep isLoading={!(pendingSafe?.txHash || pendingSafe?.taskId)} safeAddress={pendingSafe?.safeAddress}>
<Box>
<Typography variant="body2" fontWeight="700">
Validating transaction
</Typography>
{pendingSafe.txHash && (
{pendingSafe?.txHash && (
<EthHashInfo
address={pendingSafe.txHash}
hasExplorer
Expand All @@ -48,14 +90,14 @@ const StatusStepper = ({ status }: { status: SafeCreationStatus }) => {
</StatusStep>
</Step>
<Step>
<StatusStep isLoading={status < SafeCreationStatus.SUCCESS} safeAddress={pendingSafe.safeAddress}>
<StatusStep isLoading={status < SafeCreationStatus.SUCCESS} safeAddress={pendingSafe?.safeAddress}>
<Typography variant="body2" fontWeight="700">
Indexing
</Typography>
</StatusStep>
</Step>
<Step>
<StatusStep isLoading={status !== SafeCreationStatus.INDEXED} safeAddress={pendingSafe.safeAddress}>
<StatusStep isLoading={status !== SafeCreationStatus.INDEXED} safeAddress={pendingSafe?.safeAddress}>
<Typography variant="body2" fontWeight="700">
Safe Account is ready
</Typography>
Expand Down
13 changes: 13 additions & 0 deletions src/components/new-safe/create/steps/StatusStep/useIsZkEvmChain.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import useChainId from '@/hooks/useChainId'

enum ZkChains {
ZKSYNC_ERA_MAINNET = '324',
POLYGON_ZKEVM = '1101',
}

// TODO: Remove when we update SDK
export const useIsZkEvmChain = (): boolean => {
const chainId = useChainId()

return Object.values(ZkChains).includes(chainId as ZkChains)
}
katspaugh marked this conversation as resolved.
Show resolved Hide resolved