Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: WalletConnect v2 + MetaMask mobile #2444

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Fix: WalletConnect v2 + MetaMask mobile #2444

merged 1 commit into from
Aug 25, 2023

Conversation

katspaugh
Copy link
Member

What it solves

Resolves #2435

How this PR fixes it

Upgrades the onboard-core and onboard-walletconnect packages, and adds a dappUrl param in the WalletConnect options.

@katspaugh katspaugh requested a review from iamacook August 25, 2023 11:21
@github-actions
Copy link

github-actions bot commented Aug 25, 2023

Branch preview

✅ Deploy successful!

https://fix_wc_mm--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Aug 25, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it both on prod an this PR with my MM mobile app. On prod it fails with a rejection and here it works 👍

I also tested signing and executing with MM which still works.

@francovenica
Copy link
Contributor

LGTM

I can connect just fine with WV v2 using MM phone app in an iPhone
I was able to create a safe, create an execute tx (send funds, add/remove owners, tx builder)
Tested in mainnet ETH and Goerli

@katspaugh katspaugh merged commit 4fc31dc into dev Aug 25, 2023
@katspaugh katspaugh deleted the fix-wc-mm branch August 25, 2023 14:51
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot connect from MetaMask mobile via WalletConnect V2
4 participants