Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update release docs with missing step for creating final release #4489

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

jmealy
Copy link
Contributor

@jmealy jmealy commented Nov 6, 2024

A draft release is created automatically but a final release needs to be created manually from the draft. Adds in this extra step.

Copy link

github-actions bot commented Nov 6, 2024

@jmealy jmealy requested a review from compojoom November 6, 2024 09:45
Copy link

github-actions bot commented Nov 6, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Nov 6, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.04% (+0.01% 🔼)
13909/18786
🔴 Branches
52.69% (+0.02% 🔼)
3425/6500
🔴 Functions 57.84% 2029/3508
🟡 Lines
75.71% (+0.01% 🔼)
12638/16693

Test suite run success

1593 tests passing in 215 suites.

Report generated by 🧪jest coverage report action from 8b44ec9

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks like more than it is. Not sure if * or - is needed for bullet points but otherwise looks good!

@jmealy
Copy link
Contributor Author

jmealy commented Nov 6, 2024

The diff looks like more than it is. Not sure if * or - is needed for bullet points but otherwise looks good!

These changes were autoformatting, but they don't change the markdown so I guess it's just the preferred alternative

@jmealy jmealy merged commit 430f45e into dev Nov 6, 2024
15 checks passed
@jmealy jmealy deleted the release-docs branch November 6, 2024 13:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants