Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Fix regression tests #4507

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Tests: Fix regression tests #4507

merged 4 commits into from
Nov 8, 2024

Conversation

mike10ca
Copy link
Contributor

@mike10ca mike10ca commented Nov 8, 2024

What it solves

How this PR fixes it

  • Improve connect PK function to make it faster. Instead of typing, PK will be set to input's value
  • Add timeout to a multichain tests to have extra time during values load. This should resolve its flakyness
  • Add new safe for swap e2e test

How to test it

  • Run Cypress tests and observe outcome

Copy link

github-actions bot commented Nov 8, 2024

Copy link

github-actions bot commented Nov 8, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Nov 8, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 74.25% 14062/18939
🔴 Branches 52.57% 3476/6612
🔴 Functions 58.04% 2053/3537
🟡 Lines 75.88% 12774/16835

Test suite run success

1619 tests passing in 217 suites.

Report generated by 🧪jest coverage report action from 8559a19

@mike10ca mike10ca merged commit 844e44e into dev Nov 8, 2024
18 of 20 checks passed
@mike10ca mike10ca deleted the regression-tests branch November 8, 2024 13:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants