Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove old app store button #4546

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Fix: remove old app store button #4546

merged 2 commits into from
Nov 22, 2024

Conversation

katspaugh
Copy link
Member

What it solves

The old mobile app is being phased out, so removing the link to it from the footer.

Copy link

github-actions bot commented Nov 21, 2024

Copy link

github-actions bot commented Nov 21, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.38% (+0.01% 🔼)
14045/18884
🔴 Branches
52.73% (+0.02% 🔼)
3492/6622
🔴 Functions
58.21% (+0.02% 🔼)
2057/3534
🟡 Lines
76% (+0.01% 🔼)
12756/16784
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / index.tsx
66.67% (-1.52% 🔻)
0% 0%
73.68% (-1.32% 🔻)

Test suite run success

1619 tests passing in 217 suites.

Report generated by 🧪jest coverage report action from 95d77d8

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1 MB (🟢 -3.3 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@katspaugh katspaugh merged commit 6ff9e32 into dev Nov 22, 2024
15 checks passed
@katspaugh katspaugh deleted the rm-appstore branch November 22, 2024 07:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant