-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: replace @walletconnect packages with @reown/walletkit #4548
Conversation
Branch preview✅ Deploy successful! Website: Storybook: |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! |
Coverage reportCaution Test run failed
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run failedFailed tests: 0/1610. Failed suites: 1/217.
Report generated by 🧪jest coverage report action from c8355f1 |
@@ -66,7 +66,6 @@ | |||
"@sentry/react": "^7.91.0", | |||
"@spindl-xyz/attribution-lite": "^1.4.0", | |||
"@walletconnect/utils": "^2.17.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this be also taken from reown?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've asked them about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like they still recommend this package according to their docs: https://docs.reown.com/walletkit/web/installation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I would suggest to add an explicit dependency to @walletconnect/core
since we are using it as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What it solves
WalletConnect packages are now under a new namespace on npm. See https://docs.reown.com/walletkit/upgrade/from-web3wallet-web