Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add sidebar tests #4577

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Tests: Add sidebar tests #4577

merged 2 commits into from
Nov 28, 2024

Conversation

mike10ca
Copy link
Contributor

@mike10ca mike10ca commented Nov 28, 2024

What it solves

How this PR fixes it

  • Add tests for safe search and sorting in sidebar.

How to test it

  • Run Cypress tests and observe outcome.

Copy link

github-actions bot commented Nov 28, 2024

})

it('Verify search shows number of results found', () => {
let safe = main.changeSafeChainName(staticSafes.MATIC_STATIC_SAFE_28, 'eth')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let safe = main.changeSafeChainName(staticSafes.MATIC_STATIC_SAFE_28, 'eth')
const safe = main.changeSafeChainName(staticSafes.MATIC_STATIC_SAFE_28, 'eth')

})

it('Verify clearing the search input returns back to the previous lists', () => {
let safe = main.changeSafeChainName(staticSafes.MATIC_STATIC_SAFE_28, 'eth')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let safe = main.changeSafeChainName(staticSafes.MATIC_STATIC_SAFE_28, 'eth')
const safe = main.changeSafeChainName(staticSafes.MATIC_STATIC_SAFE_28, 'eth')

Copy link

github-actions bot commented Nov 28, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.01 MB (🟡 +33 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

github-actions bot commented Nov 28, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.83% (+0% 🔼)
14102/19101
🔴 Branches
51.67% (+0.12% 🔼)
3472/6720
🔴 Functions 57.27% 2052/3583
🟡 Lines
75.48% (+0% 🔼)
12812/16975
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.ts
91.92% (-0.24% 🔻)
84.15% (+3.86% 🔼)
95.45%
92.86% (-0.14% 🔻)

Test suite run success

1621 tests passing in 217 suites.

Report generated by 🧪jest coverage report action from b8faeac

@mike10ca mike10ca merged commit d8ff281 into dev Nov 28, 2024
15 checks passed
@mike10ca mike10ca deleted the sidebar-pin-tests2 branch November 28, 2024 14:12
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants