Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: display Safe App icon and name in history #4694

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Fix: display Safe App icon and name in history #4694

merged 1 commit into from
Dec 19, 2024

Conversation

katspaugh
Copy link
Member

What it solves

We weren't displaying Safe App info in the queue/history due to a regression. Safe App txs had default icons and names.

Before this PR:
Screenshot 2024-12-19 at 14 08 06

After:
Screenshot 2024-12-19 at 14 07 52

Copy link

github-actions bot commented Dec 19, 2024

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review by ChatGPT

src/hooks/useTransactionType.tsx Show resolved Hide resolved
Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1011.34 KB (-11 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 74.07% 14473/19540
🔴 Branches
51.7% (-0.01% 🔻)
3447/6667
🔴 Functions 57.13% 2056/3599
🟡 Lines 75.6% 13126/17362
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / useTransactionType.tsx
64.71% (+1.96% 🔼)
34.04% (-0.65% 🔻)
100%
65.31% (+2.04% 🔼)
🟢
... / useTxPendingStatuses.ts
77.5% (-0.83% 🔻)
64.06% (-1.56% 🔻)
68.18%
86.41% (-0.97% 🔻)

Test suite run success

1729 tests passing in 236 suites.

Report generated by 🧪jest coverage report action from 4207a7d

@katspaugh katspaugh merged commit f3a66b4 into dev Dec 19, 2024
15 of 16 checks passed
@katspaugh katspaugh deleted the icon branch December 19, 2024 14:47
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants