feat: new creation design + step 1 #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
c7cb075
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e7e57c32.web-core.pages.dev |
| Branch Preview URL: | https://step-1.web-core.pages.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
reviewed
Oct 25, 2022
katspaugh
reviewed
Oct 25, 2022
Comment on lines
1
to
7
| .back { | ||
| margin: var(--space-4) 0; | ||
| } | ||
|
|
||
| .title { | ||
| padding-bottom: var(--space-2); | ||
| } |
There was a problem hiding this comment.
These one-liners could be my={4} and pb={2} respectively.
There was a problem hiding this comment.
Button does not accept shorthands so I've added an sx to it.
iamacook
changed the base branch from
864-epic-safe-creation-redesign
to
creation
usame-algan
reviewed
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #961
How this PR fixes it
This implements the new creation/load flow layout, as well as the first step of creation. The progress bar is a placeholder as it will rely on all steps/progress and the stepper hook.
Note: the info widget is yet to be included as it has not been QA'd.
How to test it
Open
/demoand observe the new design.Screenshots